Comments on: Userstats patches with information schema support

By: Szym

Szym — Mon, 18 Aug 2008 20:29:56 +0000

Any patch to patch or more official patch against v 5.0.67 ? Thanks

By: Vadim

Vadim — Thu, 07 Aug 2008 22:34:12 +0000

Matthew,

Thanks, will look into that.

By: Matthew Kent

Matthew Kent — Thu, 07 Aug 2008 22:29:15 +0000

also noticing a funny parser issue trying to query the unquoted table name

mysql> use information_schema;
Database changed
mysql> select count(*) from table_statistics\G
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual
that corresponds to your MySQL server version for the right syntax to use near
‘table_statistics’ at line 1
mysql> select count(*) from information_schema.table_statistics\G
*************************** 1. row ***************************
count(*): 269
1 row in set (0.00 sec)

mysql> select count(*) from `table_statistics`\G
*************************** 1. row ***************************
count(*): 269
1 row in set (0.00 sec)

other than that it works great. thanks to all who contributed.

By: Matthew Kent

Matthew Kent — Thu, 07 Aug 2008 22:26:29 +0000

Hi Vadim, I’ve broken out the test suite stuff here

http://magoazul.com/tmp/userstats-is-5.0.66a-testsuite.patch

those 3 tests were failing.

By: Vadim

Vadim — Thu, 07 Aug 2008 21:48:12 +0000

Matthew,

What problem with test suite did you have ?

By: Matthew Kent

Matthew Kent — Thu, 07 Aug 2008 21:32:42 +0000

If anyone needs it I’ve rediffed this against 5.0.66a (bzr revno 2631.4.4) and included 3 more minor patches to the test suite .result files so the build cleanly passes the test suite. No code changes at all.

http://magoazul.com/tmp/userstats-is-5.0.66a.patch

By: Mark Leith

Mark Leith — Thu, 07 Aug 2008 10:12:14 +0000

Hey I’m just a lowly Support guy, it seems that you guys are having a good discussion about this with Jay however, and he’s probably the best person to be dealing with on the issues of community contributor agreements.

However, from *my* perspective, I would love to see this work included within MySQL, I think it would benefit a lot of people, and deserves to be distributed to the masses rather than the few.

I’ve raised some more awareness internally for these patches however, and people are interested in them. I hope that we can all come to some better agreement on how to include this (and other) work!

By: Baron Schwartz

Baron Schwartz — Tue, 05 Aug 2008 13:42:29 +0000

Actually, here’s my REAL opinion about the CLA:

http://groups.google.com/group/oursql-sources/msg/0a5ddd37670c8d9b?hl=en

By: Vadim

Vadim — Tue, 05 Aug 2008 03:41:18 +0000

Peter
I understand GPL difference.

I share the concerns about CLA with Baron, Mark Callaghan and Paul Paul McCullagh http://groups.google.com/group/oursql-sources/browse_thread/thread/1662e1d4d4fadc71?hl=en#

By: peter

peter — Tue, 05 Aug 2008 01:19:54 +0000

Vadim – there is no problem for US to release it as GPL however this will not be enough for inclusion in stock MySQL. In Drizzle… it should be enough.